Skip to content

[Misc] refactor example eagle #16100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2025
Merged

[Misc] refactor example eagle #16100

merged 2 commits into from
Apr 6, 2025

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Apr 5, 2025 •
edited by github-actions bot
Loading

  • refactor eagle

@github-actions
Copy link

github-actions bot commented Apr 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 5, 2025
DarkLight1337
DarkLight1337 reviewed Apr 6, 2025
View reviewed changes
reidliu41 added 2 commits April 6, 2025 16:24
@reidliu41
[Misc] refactor example eagle
47f57db 
Signed-off-by: reidliu41 <reid201711@gmail.com>
@reidliu41
remove debug
dfd90d9 
Signed-off-by: reidliu41 <reid201711@gmail.com>
@reidliu41 reidliu41 force-pushed the refactor-example-eagle branch from 3c081ea to dfd90d9 Compare April 6, 2025 08:25
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 6, 2025 08:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 6, 2025
@DarkLight1337 DarkLight1337 merged commit b6c502a into vllm-project:main Apr 6, 2025
39 of 41 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@reidliu41 @lulmer
[Misc] refactor example eagle (vllm-project#16100)
d17c534 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 7, 2025
@reidliu41 @lengrongfu
[Misc] refactor example eagle (vllm-project#16100)
32bfb85 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
@ekagra-ranjan ekagra-ranjan mentioned this pull request Apr 10, 2025
Closed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@reidliu41 @yangw-dev
[Misc] refactor example eagle (vllm-project#16100)
31bf797 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@reidliu41 @lk-chen
[Misc] refactor example eagle (vllm-project#16100)
aedf6e6 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@reidliu41
[Misc] refactor example eagle (vllm-project#16100)
daf6de3 
Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidliu41 @DarkLight1337